kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: emulator: Fix handling of VMMCALL instruction
@ 2008-12-04 11:11 Amit Shah
  2008-12-05 17:52 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Amit Shah @ 2008-12-04 11:11 UTC (permalink / raw)
  To: avi; +Cc: kvm, Amit Shah

The VMMCALL instruction doesn't get recognised and isn't processed
by the emulator.

This is seen on an Intel host that tries to execute the VMMCALL
instruction after a guest live migrates from an AMD host.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 arch/x86/kvm/x86_emulate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index 69b330b..f29e8f0 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -299,7 +299,7 @@ static u16 group_table[] = {
 
 static u16 group2_table[] = {
 	[Group7*8] =
-	SrcNone | ModRM, 0, 0, 0,
+	SrcNone | ModRM, 0, 0, SrcNone | ModRM,
 	SrcNone | ModRM | DstMem | Mov, 0,
 	SrcMem16 | ModRM | Mov, 0,
 };
-- 
1.5.6.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: emulator: Fix handling of VMMCALL instruction
  2008-12-04 11:11 [PATCH] KVM: emulator: Fix handling of VMMCALL instruction Amit Shah
@ 2008-12-05 17:52 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-12-05 17:52 UTC (permalink / raw)
  To: Amit Shah; +Cc: kvm

Amit Shah wrote:
> The VMMCALL instruction doesn't get recognised and isn't processed
> by the emulator.
>
> This is seen on an Intel host that tries to execute the VMMCALL
> instruction after a guest live migrates from an AMD host.
>
>   

Applied, thanks.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-05 17:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-04 11:11 [PATCH] KVM: emulator: Fix handling of VMMCALL instruction Amit Shah
2008-12-05 17:52 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).