From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/2] module_refcounting and anonymous inodes Date: Tue, 09 Dec 2008 15:22:42 +0200 Message-ID: <493E7122.5010904@redhat.com> References: <200812021114.59050.borntraeger@de.ibm.com> <200812091743.26586.sheng@linux.intel.com> <493E3F8B.7070603@redhat.com> <200812091108.39145.borntraeger@de.ibm.com> <493E452E.4020304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sheng Yang , kvm@vger.kernel.org, LKML To: Christian Borntraeger Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55054 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbYLINWr (ORCPT ); Tue, 9 Dec 2008 08:22:47 -0500 In-Reply-To: <493E452E.4020304@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Christian Borntraeger wrote: >> The problem is, how do you detect if the base kernel has patch1 applied? >> > > In the external module compatibility kit, implement two versions of > anon_inode_getfd(), and select the appropriate one according to kernel > version (like we currently support 91 smp_call_function_single variants). > I committed something simpler: if running on 2.6.28 or earlier, I hack out the two lines your second patch adds.\ -- error compiling committee.c: too many arguments to function