From: Avi Kivity <avi@redhat.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm-userspace: Add missing KVM string in the signature of CPUID
Date: Tue, 09 Dec 2008 15:23:51 +0200 [thread overview]
Message-ID: <493E7167.70602@redhat.com> (raw)
In-Reply-To: <20081202112930.1bf2820d@frecb000711>
Guillaume Thouvenin wrote:
> It adds a missing "KVM" string in the signature of the CPUID. Without
> it signature[2] is not well defined.
>
>
> #ifdef KVM_CPUID_SIGNATURE
> /* Paravirtualization CPUIDs */
> - memcpy(signature, "KVMKVMKVM", 12);
> + memcpy(signature, "KVMKVMKVMKVM", 12);
> pv_ent = &cpuid_ent[cpuid_nent++];
> memset(pv_ent, 0, sizeof(*pv_ent));
> pv_ent->function = KVM_CPUID_SIGNATURE;
>
That's not what the kernel is looking for. Add three '\0's instead.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-12-09 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 10:29 [PATCH] kvm-userspace: Add missing KVM string in the signature of CPUID Guillaume Thouvenin
2008-12-09 13:23 ` Avi Kivity [this message]
2008-12-09 14:13 ` [PATCH] kvm-userspace: Add '\0' at the end of " Guillaume Thouvenin
2008-12-09 14:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493E7167.70602@redhat.com \
--to=avi@redhat.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).