From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm-userspace: Add missing KVM string in the signature
 of CPUID
Date: Tue, 09 Dec 2008 15:23:51 +0200
Message-ID: <493E7167.70602@redhat.com>
References: <20081202112930.1bf2820d@frecb000711>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:55084 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752519AbYLINX6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 9 Dec 2008 08:23:58 -0500
In-Reply-To: <20081202112930.1bf2820d@frecb000711>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Guillaume Thouvenin wrote:
> It adds a missing "KVM" string in the signature of the CPUID. Without
> it signature[2] is not well defined.
>
>  
>  #ifdef KVM_CPUID_SIGNATURE
>      /* Paravirtualization CPUIDs */
> -    memcpy(signature, "KVMKVMKVM", 12);
> +    memcpy(signature, "KVMKVMKVMKVM", 12);
>      pv_ent = &cpuid_ent[cpuid_nent++];
>      memset(pv_ent, 0, sizeof(*pv_ent));
>      pv_ent->function = KVM_CPUID_SIGNATURE;
>   


That's not what the kernel is looking for.  Add three '\0's instead.

-- 
error compiling committee.c: too many arguments to function