kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "André Przywara" <osp@andrep.de>
Cc: Anthony Liguori <anthony@codemonkey.ws>, kvm@vger.kernel.org
Subject: Re: [PATCH 0/3] v2: KVM-userspace: add NUMA support for guests
Date: Tue, 09 Dec 2008 16:24:53 +0200	[thread overview]
Message-ID: <493E7FB5.80606@redhat.com> (raw)
In-Reply-To: <493D95A9.1090307@andrep.de>

André Przywara wrote:
>>> But I wouldn't load the admin with the burden of pinning, but let 
>>> this be done by QEMU/KVM. Maybe one could introduce a way to tell 
>>> QEMU/KVM to not pin the threads.
>> This is where things start to get ugly...
> Why? qemu-system-x86_64 -numa 2,pin:none and then use whatever method 
> you prefer (taskset, monitor) to pin the VCPUs (or left them unpinned).

I agree that for e.g. -numa 2, no host binding should occur.  Pinning 
memory or cpus to nodes should only occur if the user explicitly 
requested it.  Otherwise we run the risk of breaking load balancing.

If the user chooses to pin, the responsibility is on them.  If not, we 
should allow the host to do its thing.

> // similar to numactl --hardware, * means all nodes (no pinning)
>  > numa pin:0;3
> // static pinning: guest 0 -> host 0, guest 1 -> host 3
>  > numa pin:*;
> // guest node 0 -> all nodes, guest node 1: keep as it is
> // or maybe: numa pin:0-3;
>  > numa migrate:1;2

I suggest using exactly the same syntax as the command line option.  
Qemu would compute the difference between the current configuration and 
the desired configuration and migrate vcpus and memory as needed.

-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2008-12-09 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 13:29 [PATCH 0/3] v2: KVM-userspace: add NUMA support for guests Andre Przywara
2008-12-05 14:28 ` Anthony Liguori
2008-12-05 15:22   ` Andre Przywara
2008-12-05 15:41     ` Anthony Liguori
2008-12-08 21:46       ` André Przywara
2008-12-08 22:01         ` Anthony Liguori
2008-12-09 14:24         ` Avi Kivity [this message]
2008-12-09 14:55           ` Anthony Liguori
2008-12-05 15:27   ` Avi Kivity
2008-12-05 15:34     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493E7FB5.80606@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=osp@andrep.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).