From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: MMU: optimize set_spte for page sync Date: Wed, 10 Dec 2008 11:14:42 +0200 Message-ID: <493F8882.6040801@redhat.com> References: <20081121184927.GA20607@dmt.cnet> <4929322D.7050503@redhat.com> <20081124120423.GB4379@dmt.cnet> <20081124132306.GA13532@dmt.cnet> <492C0DD5.7070206@redhat.com> <20081125145807.GA14994@dmt.cnet> <492D2F14.2070705@redhat.com> <20081209155258.GA13317@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Eduardo Habkost , Chris Wright To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59561 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbYLJJOp (ORCPT ); Wed, 10 Dec 2008 04:14:45 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBA9Eje8022303 for ; Wed, 10 Dec 2008 04:14:45 -0500 In-Reply-To: <20081209155258.GA13317@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > Do you have objections for submitting this patch for 2.6.28 ? The hash > lookup kills performance of pagetable write + context switch intensive > workloads. > Can you quantify? 2.6.28 is out of the question, 2.6.28.stable is possible, depending on the actual performance difference. I'd hate to introduce a correctness problem just to improve performance. -- error compiling committee.c: too many arguments to function