From: Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: fix handling of ACK from shared guest IRQ
Date: Wed, 10 Dec 2008 11:33:06 +0200 [thread overview]
Message-ID: <493F8CD2.90707@redhat.com> (raw)
In-Reply-To: <1228220193.3870.94.camel@blaa>
Mark McLoughlin wrote:
> If an assigned device shares a guest irq with an emulated
> device then we currently interpret an ack generated by the
> emulated device as originating from the assigned device
> leading to e.g. "Unbalanced enable for IRQ 4347" from the
> enable_irq() in kvm_assigned_dev_ack_irq().
>
> The fix is fairly simple - don't enable the physical device
> irq unless it was previously disabled.
>
> Of course, this can still lead to a situation where a
> non-assigned device ACK can cause the physical device irq to
> be reenabled before the device was serviced. However, being
> level sensitive, the interrupt will merely be regenerated.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-12-10 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 12:16 [PATCH] KVM: fix handling of ACK from shared guest IRQ Mark McLoughlin
2008-12-10 9:33 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493F8CD2.90707@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).