From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: fix handling of ACK from shared guest IRQ Date: Wed, 10 Dec 2008 11:33:06 +0200 Message-ID: <493F8CD2.90707@redhat.com> References: <1228220193.3870.94.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44273 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbYLJJdK (ORCPT ); Wed, 10 Dec 2008 04:33:10 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBA9X9GA025354 for ; Wed, 10 Dec 2008 04:33:09 -0500 In-Reply-To: <1228220193.3870.94.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > If an assigned device shares a guest irq with an emulated > device then we currently interpret an ack generated by the > emulated device as originating from the assigned device > leading to e.g. "Unbalanced enable for IRQ 4347" from the > enable_irq() in kvm_assigned_dev_ack_irq(). > > The fix is fairly simple - don't enable the physical device > irq unless it was previously disabled. > > Of course, this can still lead to a situation where a > non-assigned device ACK can cause the physical device irq to > be reenabled before the device was serviced. However, being > level sensitive, the interrupt will merely be regenerated. > > Applied, thanks. -- error compiling committee.c: too many arguments to function