From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails Date: Wed, 10 Dec 2008 12:28:20 +0200 Message-ID: <493F99C4.2090906@redhat.com> References: <> <1227892250-14386-1-git-send-email-markmc@redhat.com> <1227892250-14386-2-git-send-email-markmc@redhat.com> <1227892250-14386-3-git-send-email-markmc@redhat.com> <1228904623.5384.44.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37823 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754684AbYLJK2X (ORCPT ); Wed, 10 Dec 2008 05:28:23 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBAASN0Q001506 for ; Wed, 10 Dec 2008 05:28:23 -0500 In-Reply-To: <1228904623.5384.44.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: >> fprintf(stderr, "Could not add assigned device %s\n", devices[i]); >> continue; >> + exit(1); >> > > Um, that's a rather embarrassing thinko. > For the reviewer as well; applied. -- error compiling committee.c: too many arguments to function