Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

[Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

Hollis Blanchard wrote:
> On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote:
>   
>> Hollis Blanchard wrote:
>>     
>>> On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote:
>>>       
>>>> This is v2 as version one had a type in it occured when splitting patches.
>>>> Mercurial somehow lost my changes to the patch description explaining 
>>>> that, but the patch is right this way.
>>>>
>>>> Christian Ehrhardt wrote:
>>>>         
>>>>> # HG changeset patch
>>>>> # User Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org>
>>>>> # Date 1228999833 -3600
>>>>> # Node ID dc1466c9077ab162f4637fffee1869f26be02299
>>>>> # Parent  4c07fe2a56c7653a9113e05bb08c2de9aec210ce
>>>>> [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub
>>>>>
>>>>> From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA-XMD5yJDbdMRS5n6/RkiaJA@public.gmane.orgne.org>
>>>>>
>>>>> Add basic KVM PowerPC support to qemu's gdbstub introducing a kvm ppc style
>>>>> mmu implementation that uses the kvm_translate ioctl.
>>>>> This also requires to save the kvm registers prior to the 'm' gdb operations.
>>>>>
>>>>> Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>>>> Signed-off-by: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org>
>>>>>           
>>> Let's *not* apply this to kvm-userspace. We will submit this to qemu,
>>> and once we work out the right solution there it will be merged
>>> naturally.
>>>
>>>       
>> I don't oversee yet what you want to push upstream, but in case it's the
>> gdbstub support for kvm (including ppc bits): please note that I plan to
>> push the new interface once it is merged into kvm-userspace, avoiding to
>> spread the current, limited one as far as possible.
>>
>> BTW, would be great if you could have a look / provide patches for ppc
>> to support the new interface already. I am open for feedback,
>> specifically regarding its suitability beyond x86.
>>     
>
> I've been meaning to do this for a while, sorry. We'll take a look soon.
>
>   
Hi Jan,
I saw that you already had that env->s->g_cpu fix, so if you change all that
anyway it might really be better to test/extend your patches for powerpc 
now.

If it is ok for you I would submit my patches that apply on top of yours to
you and cc the kvm list. But as Hollis mentioned I would prefer go for qemu
upstream first and then assist Avi in merging it into kvm-userspace because
this is the natural direction patches flow atm (and if you need to change it
multiple times until you get qemu acceptance you would have to extensivly
patch both projects to match again).

As my code in that case depend on your patches it would be nice if you could
put them into your series once you are happy with it.

-- 

Grüsse / regards, 
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html