From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub Date: Fri, 12 Dec 2008 13:42:19 +0100 Message-ID: <49425C2B.5040701@linux.vnet.ibm.com> References: <49410D61.9090309@linux.vnet.ibm.com> <1229010795.26586.0.camel@localhost.localdomain> <49413A5A.8090008@siemens.com> <1229020274.26586.24.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Kiszka , Avi Kivity , kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-devel To: Hollis Blanchard Return-path: In-Reply-To: <1229020274.26586.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote: > =20 >> Hollis Blanchard wrote: >> =20 >>> On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote: >>> =20 >>>> This is v2 as version one had a type in it occured when splitting = patches. >>>> Mercurial somehow lost my changes to the patch description explain= ing=20 >>>> that, but the patch is right this way. >>>> >>>> Christian Ehrhardt wrote: >>>> =20 >>>>> # HG changeset patch >>>>> # User Christian Ehrhardt >>>>> # Date 1228999833 -3600 >>>>> # Node ID dc1466c9077ab162f4637fffee1869f26be02299 >>>>> # Parent 4c07fe2a56c7653a9113e05bb08c2de9aec210ce >>>>> [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gd= bstub >>>>> >>>>> From: Hollis Blanchard >>>>> >>>>> Add basic KVM PowerPC support to qemu's gdbstub introducing a kvm= ppc style >>>>> mmu implementation that uses the kvm_translate ioctl. >>>>> This also requires to save the kvm registers prior to the 'm' gdb= operations. >>>>> >>>>> Signed-off-by: Hollis Blanchard >>>>> Signed-off-by: Christian Ehrhardt >>>>> =20 >>> Let's *not* apply this to kvm-userspace. We will submit this to qem= u, >>> and once we work out the right solution there it will be merged >>> naturally. >>> >>> =20 >> I don't oversee yet what you want to push upstream, but in case it's= the >> gdbstub support for kvm (including ppc bits): please note that I pla= n to >> push the new interface once it is merged into kvm-userspace, avoidin= g to >> spread the current, limited one as far as possible. >> >> BTW, would be great if you could have a look / provide patches for p= pc >> to support the new interface already. I am open for feedback, >> specifically regarding its suitability beyond x86. >> =20 > > I've been meaning to do this for a while, sorry. We'll take a look so= on. > > =20 Hi Jan, I saw that you already had that env->s->g_cpu fix, so if you change all= that anyway it might really be better to test/extend your patches for powerp= c=20 now. If it is ok for you I would submit my patches that apply on top of your= s to you and cc the kvm list. But as Hollis mentioned I would prefer go for = qemu upstream first and then assist Avi in merging it into kvm-userspace bec= ause this is the natural direction patches flow atm (and if you need to chan= ge it multiple times until you get qemu acceptance you would have to extensiv= ly patch both projects to match again). As my code in that case depend on your patches it would be nice if you = could put them into your series once you are happy with it. --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html