From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub Date: Sat, 13 Dec 2008 09:35:02 +0100 Message-ID: <494373B6.30400@web.de> References: <49410D61.9090309@linux.vnet.ibm.com> <1229010795.26586.0.camel@localhost.localdomain> <49413A5A.8090008@siemens.com> <1229020274.26586.24.camel@localhost.localdomain> <49425C2B.5040701@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4537E60FEA775F3D82DA72E3" Cc: Hollis Blanchard , Avi Kivity , kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-devel , Jan Kiszka To: Christian Ehrhardt Return-path: In-Reply-To: <49425C2B.5040701-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4537E60FEA775F3D82DA72E3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Christian Ehrhardt wrote: > Hollis Blanchard wrote: >> On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote: >> =20 >>> Hollis Blanchard wrote: >>> =20 >>>> On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote: >>>> =20 >>>>> This is v2 as version one had a type in it occured when splitting >>>>> patches. >>>>> Mercurial somehow lost my changes to the patch description >>>>> explaining that, but the patch is right this way. >>>>> >>>>> Christian Ehrhardt wrote: >>>>> =20 >>>>>> # HG changeset patch >>>>>> # User Christian Ehrhardt >>>>>> >>>>>> # Date 1228999833 -3600 >>>>>> # Node ID dc1466c9077ab162f4637fffee1869f26be02299 >>>>>> # Parent 4c07fe2a56c7653a9113e05bb08c2de9aec210ce >>>>>> [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu >>>>>> gdbstub >>>>>> >>>>>> From: Hollis Blanchard >>>>>> >>>>>> >>>>>> Add basic KVM PowerPC support to qemu's gdbstub introducing a kvm >>>>>> ppc style >>>>>> mmu implementation that uses the kvm_translate ioctl. >>>>>> This also requires to save the kvm registers prior to the 'm' gdb >>>>>> operations. >>>>>> >>>>>> Signed-off-by: Hollis Blanchard >>>>>> >>>>>> Signed-off-by: Christian Ehrhardt >>>>>> >>>>>> =20 >>>> Let's *not* apply this to kvm-userspace. We will submit this to qemu= , >>>> and once we work out the right solution there it will be merged >>>> naturally. >>>> >>>> =20 >>> I don't oversee yet what you want to push upstream, but in case it's = the >>> gdbstub support for kvm (including ppc bits): please note that I plan= to >>> push the new interface once it is merged into kvm-userspace, avoiding= to >>> spread the current, limited one as far as possible. >>> >>> BTW, would be great if you could have a look / provide patches for pp= c >>> to support the new interface already. I am open for feedback, >>> specifically regarding its suitability beyond x86. >>> =20 >> >> I've been meaning to do this for a while, sorry. We'll take a look soo= n. >> >> =20 > Hi Jan, > I saw that you already had that env->s->g_cpu fix, so if you change all= > that > anyway it might really be better to test/extend your patches for powerp= c > now. >=20 > If it is ok for you I would submit my patches that apply on top of your= s to > you and cc the kvm list. But as Hollis mentioned I would prefer go for = qemu > upstream first and then assist Avi in merging it into kvm-userspace bec= ause > this is the natural direction patches flow atm (and if you need to > change it > multiple times until you get qemu acceptance you would have to extensiv= ly > patch both projects to match again). My current roadmap is first merging kernel bits and corresponding kvm-userspace changes so that we can test both extensively in the context of full-blown kvm, and then push an adopted userspace interface into qemu. The other way around would create the risk of missing problems that only pop up under full-featured kvm (upstream is still fairly limited, specifically as there is no threaded smp support). That said, if you have (ppc-)changes that can be pushed immediately and independently, there is surely no need to wait for the kvm-gdb series. >=20 > As my code in that case depend on your patches it would be nice if you > could > put them into your series once you are happy with it. >=20 I will happily carry them, no problem. Jan --------------enig4537E60FEA775F3D82DA72E3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklDc7YACgkQniDOoMHTA+lEIwCeIhBeubMkuYxe7Fsdun3Hlf6t CGgAnjUkvORKrExaEkOFQ2lSPC3t56bU =F+QE -----END PGP SIGNATURE----- --------------enig4537E60FEA775F3D82DA72E3-- -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html