From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Rework user space NMI injection as KVM_CAP_USER_NMI Date: Sun, 14 Dec 2008 10:10:26 +0200 Message-ID: <4944BF72.4020703@redhat.com> References: <494137CE.3070203@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39372 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754818AbYLNIKb (ORCPT ); Sun, 14 Dec 2008 03:10:31 -0500 In-Reply-To: <494137CE.3070203@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > There is no point in doing the ready_for_nmi_injection/ > request_nmi_window dance with user space. First, we don't do this for > in-kernel irqchip anyway, while the code path is the same as for user > space irqchip mode. And second, there is nothing to loose if a pending > NMI is overwritten by another one (in contrast to IRQs where we have to > save the number). Actually, there is even the risk of raising spurious > NMIs this way because the reason for the held-back NMI might already be > handled while processing the first one. > > Therefore this patch creates a simplified user space NMI injection > interface, exporting it under KVM_CAP_USER_NMI and dropping the old > KVM_CAP_NMI capability. And this time we also take care to provide the > interface only on archs supporting NMIs via KVM (right now only x86). > > Thanks; applied, and will fold into the 2.6.29 merge. -- error compiling committee.c: too many arguments to function