From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: Re: [PATCH 1 of 6] [PATCH] kvm-userspace: ppc: fix compatfd build decision Date: Mon, 15 Dec 2008 13:43:44 +0100 Message-ID: <49465100.30401@linux.vnet.ibm.com> References: <4944E3E0.1050607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4944E3E0.1050607-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > >> qemu-kvm.c uses qemu_eventfd/qemu_signalfd. The code of compatfd=20 >> takes care >> if CONFIG_eventfd/CONFIG_signalfd is really enabled. But currently=20 >> compatfd is >> not build if --disable-aio is set. This patch lets compatfd.c build=20 >> if USE_KVM >> is set to allow qemu-kvm to be linked in all cases (with/without=20 >> --disable-aio) >> =20 > > This breaks x86, so I dropped it. > On the other Hand x86 it is broken atm too. If you compile current upstream for x86 with --disable-aio you'll get=20 this too: ibqemu.a(qemu-kvm.o): In function `kvm_main_loop': =20 /home/paelzer/Desktop/KVM/ppc_port/kvm-userspace-ppc.hg-testbuild/qemu/= qemu-kvm.c:565:=20 undefined reference to `qemu_eventfd' =20 /home/paelzer/Desktop/KVM/ppc_port/kvm-userspace-ppc.hg-testbuild/qemu/= qemu-kvm.c:580:=20 undefined reference to `qemu_signalfd' collect2: ld returned 1 exit status Which was exactly what I had with power :-/ I checked for the error you reported Avi, and the problem seems to be=20 that USE_KVM was not set even if KVM support is enabled (weird?). However looking at this more in detail I realized that I don't have to=20 care about USE_KVM in this csae. As I mentioned before compatfd.c takes= =20 care if CONFIG_signalfd/CONFIG_eventfd are set. Therefore we can savely= =20 remove the makefile guard completely and just always build compatfd.c. This updated patch works for x86&powerpc with/without --disable-aio in=20 my tests. It should appear on the list shortly. --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html