From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Loss of lock drop in qemu/net.c Date: Tue, 16 Dec 2008 21:38:03 +0200 Message-ID: <4948039B.7060400@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Mark McLoughlin , Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53498 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbYLPThv (ORCPT ); Tue, 16 Dec 2008 14:37:51 -0500 Sender: kvm-owner@vger.kernel.org List-ID: hThe recent qemu merged does not allow net.h to include kvm code (due to a dependency on cpu.h). This means I had to drop the kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, makes the whole thing vulnerable to hotunplug; we need refcounting or locking here). We'll need to find some way to put this back in. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.