From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: Loss of lock drop in qemu/net.c
Date: Tue, 16 Dec 2008 14:25:56 -0600
Message-ID: <49480ED4.90900@codemonkey.ws>
References: <4948039B.7060400@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark McLoughlin <markmc@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from qw-out-2122.google.com ([74.125.92.24]:46817 "EHLO
	qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1760196AbYLPU0D (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 16 Dec 2008 15:26:03 -0500
Received: by qw-out-2122.google.com with SMTP id 3so750706qwe.37
        for <kvm@vger.kernel.org>; Tue, 16 Dec 2008 12:26:02 -0800 (PST)
In-Reply-To: <4948039B.7060400@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> hThe recent qemu merged does not allow net.h to include kvm code (due 
> to a dependency on cpu.h).  This means I had to drop the 
> kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, 
> makes the whole thing vulnerable to hotunplug; we need refcounting or 
> locking here).

Why does net.h include cpu.h and why would net.h need kvm code?

Regards,

Anthony Liguori

> We'll need to find some way to put this back in.
>