From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 0/3] Add BIOS splash image support Date: Tue, 16 Dec 2008 14:28:29 -0600 Message-ID: <49480F6D.2010302@codemonkey.ws> References: <1229440810-12394-1-git-send-email-Laurent.Vivier@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm developers , bochs developers To: Blue Swirl Return-path: Received: from qw-out-2122.google.com ([74.125.92.25]:51299 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759987AbYLPU2f (ORCPT ); Tue, 16 Dec 2008 15:28:35 -0500 Received: by qw-out-2122.google.com with SMTP id 3so750982qwe.37 for ; Tue, 16 Dec 2008 12:28:34 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Blue Swirl wrote: > On 12/16/08, Laurent Vivier wrote: > >> This series of patches adds a nice BIOS startup splash screen. >> >> It adds a "-splash" option allowing to specify the picture file name (a 640x480 (or less) and true color PNG) to display. You can enable/disable fade in, >> fade out and bootmenu. The time to display the image can be also given (in >> seconds). >> >> Idea and some parts of code are stollen from VirtualBox (GPLv2/CDDL). >> >> [PATCH 1/3] Correct fw_cfg_add_callback() >> [PATCH 2/3] [BIOS] Add splash image support >> [PATCH 3/3] [QEMU] Add BIOS splash image >> > > On second thought, there is no Gtk/Qt GUI because that is supposed to > be external to Qemu. By the same logic, why should there be any splash > screen? The external GUI can probably show it as easily using the same > Gtk/Qt/whatever. You need it to be consistent on the SDL/VNC display. Modern BIOSes have splash screens. I don't see why our BIOS shouldn't have one too. > The control channel may still be needed. > > Alternatively the BIOS could load the image and fade parameters from a > new ROM or from the configuration device and draw it to screen. This > would need some PNG support to BIOS, or that the image stored in raw > form. > Yeah, having QEMU render to the VGA directly is a bit ugly. It would be nicer if the BIOS actually rendered the image but I'm not sure I think we should reject the patch just because it doesn't. Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >