From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: Loss of lock drop in qemu/net.c
Date: Wed, 17 Dec 2008 11:38:04 +0200
Message-ID: <4948C87C.6060607@redhat.com>
References: <4948039B.7060400@redhat.com> <49480ED4.90900@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark McLoughlin <markmc@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:46317 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750806AbYLQJiM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Dec 2008 04:38:12 -0500
In-Reply-To: <49480ED4.90900@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
> Avi Kivity wrote:
>> hThe recent qemu merged does not allow net.h to include kvm code (due 
>> to a dependency on cpu.h).  This means I had to drop the 
>> kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, 
>> makes the whole thing vulnerable to hotunplug; we need refcounting or 
>> locking here).
>
> Why does net.h include cpu.h and why would net.h need kvm code?
>

I meant net.c -> qemu->kvm.h -> cpu.h.

The code in question is in net.c (in tap_send).

-- 
error compiling committee.c: too many arguments to function