From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: Loss of lock drop in qemu/net.c
Date: Wed, 17 Dec 2008 11:39:40 +0200
Message-ID: <4948C8DC.9050408@redhat.com>
References: <4948039B.7060400@redhat.com> <1229505563.3685.37.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	kvm-devel <kvm@vger.kernel.org>
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:46358 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753818AbYLQJjr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Dec 2008 04:39:47 -0500
In-Reply-To: <1229505563.3685.37.camel@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mark McLoughlin wrote:
> On Tue, 2008-12-16 at 21:38 +0200, Avi Kivity wrote:
>   
>> The recent qemu merged does not allow net.h to include kvm code (due to 
>> a dependency on cpu.h).  This means I had to drop the 
>> kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, 
>> makes the whole thing vulnerable to hotunplug; we need refcounting or 
>> locking here).
>>     
>
> How can the tap vlan client be affected by hotunplug?
>   

It cannot; my mistake.

-- 
error compiling committee.c: too many arguments to function