Re: [PATCH] kvm: work around inability of older kvm modules to destroy memory regions

[Avi Kivity <avi@redhat.com>]

Christian Ehrhardt wrote:
> Hi, this patch breaks all non x86 architectures as libkvm/libkvm-x86.c 
> has the only implementation of the alias functionality.
> Until now only qemu-kvm-x86 has called that functions, but since this 
> patch the generic qemu-kvm.c calls them which leads to unresolved 
> symbols for powerpc, s390 and surely ia64 too.
>
> Well we could insert stubs for these call, but when looking on the 
> kernel side x86 is also the only implementer of the 
> KVM_SET_MEMORY_ALIAS ioctl. Until more arch support that there is no 
> reason to create these functions for non-x86 in libkvm. Also the 
> assumptions which addresses must be aliased base on hardware specific 
> assumptions e.g. vga card -> arch specific too.
>
> For now I hold a no-op stub in my private queue to test powerpc, but 
> eventually this mechanism should be arch dependent and this 
> implementation x86 only.
> Avi could you modify your patch to work for the other arch's too ?

Your band aid should be fine.  Yes, it's ugly, but this will be in flux 
as we merge with upstream qemu.  Please resend it with a signoff.

-- 
error compiling committee.c: too many arguments to function