From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 2/5] isolate io handling routing Date: Wed, 17 Dec 2008 14:54:01 -0600 Message-ID: <494966E9.90504@codemonkey.ws> References: <1229546822-11972-1-git-send-email-glommer@redhat.com> <1229546822-11972-2-git-send-email-glommer@redhat.com> <1229546822-11972-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com To: Glauber Costa Return-path: Received: from mail-ew0-f17.google.com ([209.85.219.17]:41573 "EHLO mail-ew0-f17.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbYLQUyK (ORCPT ); Wed, 17 Dec 2008 15:54:10 -0500 Received: by ewy10 with SMTP id 10so116272ewy.13 for ; Wed, 17 Dec 2008 12:54:08 -0800 (PST) In-Reply-To: <1229546822-11972-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > introduce cpu_physical_memory_do_io, which handles > the mmio part of cpu_physical_memory_rw. KVM can use > it to do mmio, since mmio is essentially the same for > both KVM and tcg. > > Signed-off-by: Glauber Costa > --- > cpu-all.h | 2 + > exec.c | 89 ++++++++++++++++++++++++++++++++++-------------------------- > 2 files changed, 52 insertions(+), 39 deletions(-) > > diff --git a/cpu-all.h b/cpu-all.h > index 648264c..d46da05 100644 > --- a/cpu-all.h > +++ b/cpu-all.h > @@ -910,6 +910,8 @@ int cpu_register_io_memory(int io_index, > CPUWriteMemoryFunc **cpu_get_io_memory_write(int io_index); > CPUReadMemoryFunc **cpu_get_io_memory_read(int io_index); > > +int cpu_physical_memory_do_io(target_phys_addr_t addr, uint8_t *buf, int l, > + int is_write, unsigned long pd); > void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, > int len, int is_write); > static inline void cpu_physical_memory_read(target_phys_addr_t addr, > diff --git a/exec.c b/exec.c > index 44f6a42..04eadfe 100644 > --- a/exec.c > +++ b/exec.c > @@ -2891,12 +2891,58 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, > } > > #else > +int cpu_physical_memory_do_io(target_phys_addr_t addr, uint8_t *buf, int l, int is_write, unsigned long pd) > +{ > + int io_index; > + uint32_t val; > + > + io_index = (pd >> IO_MEM_SHIFT) & (IO_MEM_NB_ENTRIES - 1); > + if (is_write) { > + /* XXX: could force cpu_single_env to NULL to avoid > That's some big identing :-) Regards, Anthony Liguori