From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5] cache slot lookup Date: Thu, 18 Dec 2008 13:24:47 +0200 Message-ID: <494A32FF.80103@redhat.com> References: <1229546822-11972-1-git-send-email-glommer@redhat.com> <1229546822-11972-2-git-send-email-glommer@redhat.com> <1229546822-11972-3-git-send-email-glommer@redhat.com> <1229546822-11972-4-git-send-email-glommer@redhat.com> <1229546822-11972-5-git-send-email-glommer@redhat.com> <1229546822-11972-6-git-send-email-glommer@redhat.com> <494A1AC4.30704@redhat.com> <20081218104850.GB19123@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59949 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbYLRLYx (ORCPT ); Thu, 18 Dec 2008 06:24:53 -0500 In-Reply-To: <20081218104850.GB19123@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: >> This wasn't introduced by this patch, but the comparison is broken ion >> i386 hosts, where target_phys_addr_t is 32 bits wide. mem->start_addr + >> mem->memory_size can overflow (this in fact happens for the bios slot at >> 4G-128K) >> > AFAIK, the assumption is that kvm will always be qemu-system-x86_64, due to > migration issues. That's an incorrect assumption. Users are free to build any qemu variant they like. 32-bit qemu ought to work. > Then, _target_ phys_addr_t is always 64 bit wide. > It is not. On a 32-bit host, qemu-system-x87_43's target_phys_addr_t is 32 bits wide. > If it's not the case, then this is really a problem. > It isn't, so it is. I hacked around it in kvm-userspace. -- error compiling committee.c: too many arguments to function