From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: qemu: virtio-net: set info_str Date: Tue, 23 Dec 2008 19:23:51 +0200 Message-ID: <49511EA7.1090704@redhat.com> References: <1228820282.26198.6.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40861 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbYLWRXy (ORCPT ); Tue, 23 Dec 2008 12:23:54 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBNHNsnB031684 for ; Tue, 23 Dec 2008 12:23:54 -0500 In-Reply-To: <1228820282.26198.6.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Currently 'info network' shows no details for a virtio nic. > > Sorry, I've missed this. But now virtio-net is in qemu; can you push it there, and I'll merge it in due course? > Signed-off-by: Mark McLoughlin > --- > qemu/hw/virtio-net.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c > index da2e835..18da625 100644 > --- a/qemu/hw/virtio-net.c > +++ b/qemu/hw/virtio-net.c > @@ -403,6 +403,11 @@ PCIDevice *virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn) > n->vc = qemu_new_vlan_client(nd->vlan, virtio_net_receive, > virtio_net_can_receive, n); > > + snprintf(n->vc->info_str, sizeof(n->vc->info_str), > + "virtio macaddr=%02x:%02x:%02x:%02x:%02x:%02x", > + n->mac[0], n->mac[1], n->mac[2], > + n->mac[3], n->mac[4], n->mac[5]); > + > n->tx_timer = qemu_new_timer(vm_clock, virtio_net_tx_timer, n); > n->tx_timer_active = 0; > n->mergeable_rx_bufs = 0; > -- error compiling committee.c: too many arguments to function