Re: [PATCH] Fix KVM includes in helper.c

[Avi Kivity <avi@redhat.com>]

Alexander Graf wrote:
> By default target-i386/helper.c does not include config.h, so
> no code in there knows if we're enabling KVM or not.
> This breaks the nested activation, as that's depending on the
> config options.
>
> Of course, with this patch applied the CPUID KVM checks are
> applied twice, as now kvm_enabled() does not default to true
> for the cpuid helper functions. Maybe it's a good idea to
> remove the qemu-kvm-x86.c cpuid code?
>
> This patch fixes compilation broken thanks to my nested SVM
> patches.
>
> @@ -30,6 +30,7 @@
>  #include "qemu-common.h"
>  #include "kvm.h"
>  
> +#include "config.h"
>  #include "qemu-kvm.h"
>  

Isn't this a problem with upstream qemu as well?

-- 
error compiling committee.c: too many arguments to function