From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix KVM includes in helper.c Date: Wed, 24 Dec 2008 12:38:19 +0200 Message-ID: <4952111B.9030507@redhat.com> References: <1229964850-23316-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33752 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbYLXKiZ (ORCPT ); Wed, 24 Dec 2008 05:38:25 -0500 In-Reply-To: <1229964850-23316-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > By default target-i386/helper.c does not include config.h, so > no code in there knows if we're enabling KVM or not. > This breaks the nested activation, as that's depending on the > config options. > > Of course, with this patch applied the CPUID KVM checks are > applied twice, as now kvm_enabled() does not default to true > for the cpuid helper functions. Maybe it's a good idea to > remove the qemu-kvm-x86.c cpuid code? > > This patch fixes compilation broken thanks to my nested SVM > patches. > > @@ -30,6 +30,7 @@ > #include "qemu-common.h" > #include "kvm.h" > > +#include "config.h" > #include "qemu-kvm.h" > Isn't this a problem with upstream qemu as well? -- error compiling committee.c: too many arguments to function