From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix KVM includes in helper.c Date: Wed, 24 Dec 2008 13:33:08 +0200 Message-ID: <49521DF4.6000206@redhat.com> References: <1229964850-23316-1-git-send-email-agraf@suse.de> <4952111B.9030507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38195 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbYLXLdN (ORCPT ); Wed, 24 Dec 2008 06:33:13 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > kvm.h includes config.h - I'm puzzled. Oh, it doesn't in kvm-userspace. I'll fix it. Qemu should probably move to -include "config.h" instead of relying on all users to include it, since it will fail silently instead of complaining. -- error compiling committee.c: too many arguments to function