From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: Re: [PATCH 0/2] remove kvm vmap usage Date: Mon, 29 Dec 2008 02:06:55 +0200 Message-ID: <4958149F.10101@redhat.com> References: <1230507740-10596-1-git-send-email-ieidus@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: avi@redhat.com To: kvm@vger.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35082 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbYL2AHW (ORCPT ); Sun, 28 Dec 2008 19:07:22 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBT07LSj022763 for ; Sun, 28 Dec 2008 19:07:21 -0500 In-Reply-To: <1230507740-10596-1-git-send-email-ieidus@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Izik Eidus wrote: > Remove the vmap usage from kvm, this is needed both for ksm and > get_user_pages != write. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Ok so for ksm things are now all right, actully i could live without this vmap as well, beacuse ksm check the page _count and every call to gva_to_page should increase it. anyway before i continue with the kmap removing (again ksm doesnt need it, only get_user_pages != write) does we really want to go that way? even for the get_user_pages case we can live with the write = 0, if before each kmap_atomic we will call get_user_pages (write = 1), so the page inside apic_page and time_page and what so ever would be safe (when ksm will come to merge that page it will skip it with the page count check)