From: Avi Kivity <avi@redhat.com>
To: "Liu, Kechao" <kechao.liu@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Shan, Haitao" <haitao.shan@intel.com>
Subject: Re: [PATCH][v2] kvm-userspace: Load PCI option ROMs
Date: Mon, 29 Dec 2008 10:28:58 +0200 [thread overview]
Message-ID: <49588A4A.8020902@redhat.com> (raw)
In-Reply-To: <E88DD564E9DC5446A76B2B47C3BCCA15434793BC@pdsmsx503.ccr.corp.intel.com>
Liu, Kechao wrote:
> Hi Avi,
>
> Thanks for your comments. I've updated the patch according to them.
> Please review it. Thank you.
>
> Load assigned devices' PCI option ROMs to the RAM of
> guest OS. And pass the corresponding devfns to BIOS.
>
>
Looks good.
> +
> + /* Write ROM data and devfn to phys_addr */
> + cpu_physical_memory_write_rom(0xd0000 + offset, rom, size);
> + cpu_physical_memory_write_rom(0xd0000 + offset + size, &devfn, 1);
> +
How is the last bit performed on real hardware? Obviously the ROM can't
have devfn embedded.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-12-29 8:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 3:51 [PATCH][v2] kvm-userspace: Load PCI option ROMs Liu, Kechao
2008-12-29 8:28 ` Avi Kivity [this message]
2008-12-29 9:36 ` Liu, Kechao
2008-12-29 9:49 ` Avi Kivity
2008-12-30 1:01 ` Shan, Haitao
2008-12-30 15:51 ` Avi Kivity
2008-12-31 2:06 ` Shan, Haitao
2008-12-31 9:28 ` Avi Kivity
2009-01-03 2:29 ` Shan, Haitao
2009-01-04 2:12 ` Shan, Haitao
2009-01-04 3:54 ` Leendert van Doorn
2009-01-04 4:58 ` Shan, Haitao
2009-01-04 10:26 ` Avi Kivity
2009-01-04 17:12 ` Leendert van Doorn
2009-01-04 17:28 ` Avi Kivity
2009-01-04 17:29 ` Avi Kivity
2009-01-04 17:54 ` Leendert van Doorn
2009-01-04 19:51 ` Avi Kivity
2009-01-04 18:03 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49588A4A.8020902@redhat.com \
--to=avi@redhat.com \
--cc=haitao.shan@intel.com \
--cc=kechao.liu@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox