From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH][v2] kvm-userspace: Load PCI option ROMs
Date: Mon, 29 Dec 2008 10:28:58 +0200
Message-ID: <49588A4A.8020902@redhat.com>
References: <E88DD564E9DC5446A76B2B47C3BCCA15434793BC@pdsmsx503.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Shan, Haitao" <haitao.shan@intel.com>
To: "Liu, Kechao" <kechao.liu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41001 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752468AbYL2I2o (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 29 Dec 2008 03:28:44 -0500
In-Reply-To: <E88DD564E9DC5446A76B2B47C3BCCA15434793BC@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Liu, Kechao wrote:
> Hi Avi,
>
> Thanks for your comments. I've updated the patch according to them.
> Please review it. Thank you.
>
> Load assigned devices' PCI option ROMs to the RAM of
> guest OS. And pass the corresponding devfns to BIOS.
>
>   

Looks good.

> +    
> +    /* Write ROM data and devfn to phys_addr */
> +    cpu_physical_memory_write_rom(0xd0000 + offset, rom, size);
> +    cpu_physical_memory_write_rom(0xd0000 + offset + size, &devfn, 1);
> +   

How is the last bit performed on real hardware?  Obviously the ROM can't 
have devfn embedded.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.