From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 1/2] libkvm: pit not reinject support
Date: Tue, 30 Dec 2008 12:09:34 +0200
Message-ID: <4959F35E.3080004@redhat.com>
References: <20081229174233.165653613@localhost.localdomain> <20081229174406.057184458@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, sheng@linux.intel.com
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:36682 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751351AbYL3KJh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 30 Dec 2008 05:09:37 -0500
In-Reply-To: <20081229174406.057184458@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Index: kvm-userspace.pit/libkvm/libkvm-x86.c
> ===================================================================
> --- kvm-userspace.pit.orig/libkvm/libkvm-x86.c
> +++ kvm-userspace.pit/libkvm/libkvm-x86.c
> @@ -75,6 +75,20 @@ int kvm_create_pit(kvm_context_t kvm)
>  	return 0;
>  }
>  
> +int kvm_pit_no_reinjection(kvm_context_t kvm)
> +{
> +#ifdef KVM_CAP_PIT_NO_REINJECT
> +    int r;
> +
> +    r = ioctl(kvm->fd, KVM_CHECK_EXTENSION, KVM_CAP_PIT_NO_REINJECT);
> +    if (r > 0) {
> +        r = ioctl(kvm->vm_fd, KVM_PIT_NO_REINJECT);
> +        return r;
> +    }
> +#endif
> +    return -1;
> +}
>   

Most (not all unfortunately) return -errno on error.

>  
> +int kvm_pit_no_reinjection(kvm_context_t kvm);
> +
>   

Don't use nonpositive logic.

-- 
error compiling committee.c: too many arguments to function