From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] KVM: Add MSI_ACTION flag for assigned irq Date: Tue, 30 Dec 2008 12:19:29 +0200 Message-ID: <4959F5B1.60100@redhat.com> References: <1230616173-17723-1-git-send-email-sheng@linux.intel.com> <1230616173-17723-2-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33629 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbYL3KTe (ORCPT ); Tue, 30 Dec 2008 05:19:34 -0500 In-Reply-To: <1230616173-17723-2-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > For MSI disable feature later. > > Notice I changed ABI here, but due to no userspace patch, I think it's OK. > It's not okay, since eventually we will have userspace and it will have to work with older kernels as well. No released kernel has KVM_DEV_IRQ_ASSIGN_ENABLE_MSI, so it's fine, provided I fold this into the 2.6.29 submission. However, why do this at all? It can only cause confusion. -- error compiling committee.c: too many arguments to function