Re: [PATCH 2/3] Don't return to guest after CPU issued S3 command.

[Avi Kivity <avi@redhat.com>]

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  qemu/hw/acpi.c  |    2 +-
>  qemu/qemu-kvm.c |    2 +-
>  qemu/qemu-kvm.h |    1 +
>  3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
> index 0ff8851..219d8ac 100644
> --- a/qemu/hw/acpi.c
> +++ b/qemu/hw/acpi.c
> @@ -159,7 +159,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val)
>                      /* RSM_STS should be set on resume. Pretend that resume
>                         was caused by power button */
>                      s->pmsts |= (RSM_STS | PWRBTN_STS);
> -                    qemu_system_reset_request();
> +                    kvm_shutdown(NULL, cpu_single_env);
>   

if (kvm_enabled)()?

But I think a qemu API is called for here, not a kvm specific API.


> +int kvm_shutdown(void *opaque, void *data); 

That's a bad API.  What's the opaque?  what's the data?


-- 
error compiling committee.c: too many arguments to function