From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] Don't return to guest after CPU issued S3 command. Date: Tue, 30 Dec 2008 13:19:22 +0200 Message-ID: <495A03BA.5060701@redhat.com> References: <20081230103712.5604.20753.stgit@dhcp-1-237.tlv.redhat.com> <20081230103723.5604.46564.stgit@dhcp-1-237.tlv.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42791 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbYL3LTZ (ORCPT ); Tue, 30 Dec 2008 06:19:25 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBUBJOcT031793 for ; Tue, 30 Dec 2008 06:19:24 -0500 In-Reply-To: <20081230103723.5604.46564.stgit@dhcp-1-237.tlv.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > --- > > qemu/hw/acpi.c | 2 +- > qemu/qemu-kvm.c | 2 +- > qemu/qemu-kvm.h | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c > index 0ff8851..219d8ac 100644 > --- a/qemu/hw/acpi.c > +++ b/qemu/hw/acpi.c > @@ -159,7 +159,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val) > /* RSM_STS should be set on resume. Pretend that resume > was caused by power button */ > s->pmsts |= (RSM_STS | PWRBTN_STS); > - qemu_system_reset_request(); > + kvm_shutdown(NULL, cpu_single_env); > if (kvm_enabled)()? But I think a qemu API is called for here, not a kvm specific API. > +int kvm_shutdown(void *opaque, void *data); That's a bad API. What's the opaque? what's the data? -- error compiling committee.c: too many arguments to function