public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: Use kvm_free_assigned_irq() for free irq
Date: Tue, 30 Dec 2008 13:27:22 +0200	[thread overview]
Message-ID: <495A059A.3030206@redhat.com> (raw)
In-Reply-To: <200812301922.51604.sheng@linux.intel.com>

Sheng Yang wrote:
> So still, how about deal with this at the beginning of kvm_destory_vm? Discard 
> currently reference count. In the function, disable all known interrupt(and 
> result some nested disabled but we would free them later), then 
> cancel_work_sync(). At this time, I think the state is legal(at least 
> workable).
>   

Certainly, if it's the first thing we do, it's legal (and the mutex is 
valid etc.)

Just be sure to add a nice comment there.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-12-30 11:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30  5:49 [0/3][RESEND] Device assignment code clean up and MSI disable support Sheng Yang
2008-12-30  5:49 ` [PATCH 1/3] KVM: Add MSI_ACTION flag for assigned irq Sheng Yang
2008-12-30 10:19   ` Avi Kivity
2008-12-30 10:26     ` Sheng Yang
2008-12-30 10:31       ` Avi Kivity
2008-12-30 10:34         ` Sheng Yang
2008-12-30 10:41           ` Avi Kivity
2008-12-30 10:48             ` Sheng Yang
2008-12-30  5:49 ` [PATCH 2/3] KVM: Use kvm_free_assigned_irq() for free irq Sheng Yang
2008-12-30 10:28   ` Avi Kivity
2008-12-30 11:11     ` Sheng Yang
2008-12-30 11:16       ` Avi Kivity
2008-12-30 11:22         ` Sheng Yang
2008-12-30 11:27           ` Avi Kivity [this message]
2008-12-30  5:49 ` [PATCH 3/3] KVM: Add support to disable MSI for assigned device Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495A059A.3030206@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox