From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: Use kvm_free_assigned_irq() for free irq Date: Tue, 30 Dec 2008 13:27:22 +0200 Message-ID: <495A059A.3030206@redhat.com> References: <1230616173-17723-1-git-send-email-sheng@linux.intel.com> <200812301911.10975.sheng@linux.intel.com> <495A030B.1040302@redhat.com> <200812301922.51604.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46877 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753420AbYL3L1Z (ORCPT ); Tue, 30 Dec 2008 06:27:25 -0500 In-Reply-To: <200812301922.51604.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > So still, how about deal with this at the beginning of kvm_destory_vm? Discard > currently reference count. In the function, disable all known interrupt(and > result some nested disabled but we would free them later), then > cancel_work_sync(). At this time, I think the state is legal(at least > workable). > Certainly, if it's the first thing we do, it's legal (and the mutex is valid etc.) Just be sure to add a nice comment there. -- error compiling committee.c: too many arguments to function