From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] Don't return to guest after CPU issued S3 command. Date: Tue, 30 Dec 2008 15:25:29 +0200 Message-ID: <495A2149.5000106@redhat.com> References: <20081230103712.5604.20753.stgit@dhcp-1-237.tlv.redhat.com> <20081230103723.5604.46564.stgit@dhcp-1-237.tlv.redhat.com> <495A03BA.5060701@redhat.com> <20081230123256.GB3326@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51337 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbYL3NZf (ORCPT ); Tue, 30 Dec 2008 08:25:35 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBUDPYjS018229 for ; Tue, 30 Dec 2008 08:25:34 -0500 In-Reply-To: <20081230123256.GB3326@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > On Tue, Dec 30, 2008 at 01:19:22PM +0200, Avi Kivity wrote: > >>> +int kvm_shutdown(void *opaque, void *data); >>> >> That's a bad API. What's the opaque? what's the data? >> >> > How about this one: > > Don't return to guest CPU after qemu_system_reset_request(). > Applied, thanks. -- error compiling committee.c: too many arguments to function