From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][v2] kvm-userspace: Load PCI option ROMs Date: Tue, 30 Dec 2008 17:51:03 +0200 Message-ID: <495A4367.6050203@redhat.com> References: <49588A4A.8020902@redhat.com> <49589D21.9070201@redhat.com> <61563CE63B4F854986A895DA7AD3C177044E6ECA@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Liu, Kechao" , "'kvm@vger.kernel.org'" To: "Shan, Haitao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39424 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbYL3PvH (ORCPT ); Tue, 30 Dec 2008 10:51:07 -0500 In-Reply-To: <61563CE63B4F854986A895DA7AD3C177044E6ECA@pdsmsx502.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Shan, Haitao wrote: >> Well, it may make sense to provide the ROMs as virtual PCI BARs, and >> have the bios do the work. This way, if some driver relies on >> remapping the BAR (graphic cards?), it can still work. >> > > I do not quite understand this. Can you elaborate? > Which part? I propose not to copy the card option rom to the bios. Instead, present the bios as a virtual PCI BAR. The loop that scans the ROMs can then be moved to the bios. The advantage is that if a driver needs something in the ROM (mode tables for graphics), they will be available. I don't know if any card actually requires this. Maybe all the information is in the driver. -- error compiling committee.c: too many arguments to function