From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] kvm: bios: KVM does not support SMM, so disable it Date: Tue, 30 Dec 2008 10:34:13 -0600 Message-ID: <495A4D85.7020305@codemonkey.ws> References: <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: Received: from yx-out-2324.google.com ([74.125.44.29]:53368 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbYL3QeU (ORCPT ); Tue, 30 Dec 2008 11:34:20 -0500 Received: by yx-out-2324.google.com with SMTP id 8so1663196yxm.1 for ; Tue, 30 Dec 2008 08:34:19 -0800 (PST) In-Reply-To: <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > From: Gleb Natapov > > Signed-off-by: Gleb Natapov > Signed-off-by: Avi Kivity > > diff --git a/bios/rombios32.c b/bios/rombios32.c > index fd6ff71..a0c9572 100755 > --- a/bios/rombios32.c > +++ b/bios/rombios32.c > @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t; > //#define BX_USE_EBDA_TABLES > > /* define it if the (emulated) hardware supports SMM mode */ > -#define BX_USE_SMM > +//#define BX_USE_SMM > We already disable SMM in acpi.c:piix4_pm_init() by setting the SMM inited bit in the PCI config space for the piix4. It's hackish, but it avoids needing a KVM-specific BIOS. Regards, Anthony Liguori > #define cpuid(index, eax, ebx, ecx, edx) \ > asm volatile ("cpuid" \ > -- > To unsubscribe from this list: send the line "unsubscribe kvm-commits" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >