* Re: [PATCH] kvm: bios: KVM does not support SMM, so disable it [not found] <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com> @ 2008-12-30 16:34 ` Anthony Liguori 2008-12-31 6:45 ` Gleb Natapov 0 siblings, 1 reply; 2+ messages in thread From: Anthony Liguori @ 2008-12-30 16:34 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel Avi Kivity wrote: > From: Gleb Natapov <gleb@redhat.com> > > Signed-off-by: Gleb Natapov <gleb@redhat.com> > Signed-off-by: Avi Kivity <avi@redhat.com> > > diff --git a/bios/rombios32.c b/bios/rombios32.c > index fd6ff71..a0c9572 100755 > --- a/bios/rombios32.c > +++ b/bios/rombios32.c > @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t; > //#define BX_USE_EBDA_TABLES > > /* define it if the (emulated) hardware supports SMM mode */ > -#define BX_USE_SMM > +//#define BX_USE_SMM > We already disable SMM in acpi.c:piix4_pm_init() by setting the SMM inited bit in the PCI config space for the piix4. It's hackish, but it avoids needing a KVM-specific BIOS. Regards, Anthony Liguori > #define cpuid(index, eax, ebx, ecx, edx) \ > asm volatile ("cpuid" \ > -- > To unsubscribe from this list: send the line "unsubscribe kvm-commits" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: bios: KVM does not support SMM, so disable it 2008-12-30 16:34 ` [PATCH] kvm: bios: KVM does not support SMM, so disable it Anthony Liguori @ 2008-12-31 6:45 ` Gleb Natapov 0 siblings, 0 replies; 2+ messages in thread From: Gleb Natapov @ 2008-12-31 6:45 UTC (permalink / raw) To: Anthony Liguori; +Cc: Avi Kivity, kvm-devel On Tue, Dec 30, 2008 at 10:34:13AM -0600, Anthony Liguori wrote: > Avi Kivity wrote: >> From: Gleb Natapov <gleb@redhat.com> >> >> Signed-off-by: Gleb Natapov <gleb@redhat.com> >> Signed-off-by: Avi Kivity <avi@redhat.com> >> >> diff --git a/bios/rombios32.c b/bios/rombios32.c >> index fd6ff71..a0c9572 100755 >> --- a/bios/rombios32.c >> +++ b/bios/rombios32.c >> @@ -38,7 +38,7 @@ typedef unsigned long long uint64_t; >> //#define BX_USE_EBDA_TABLES >> /* define it if the (emulated) hardware supports SMM mode */ >> -#define BX_USE_SMM >> +//#define BX_USE_SMM >> > > We already disable SMM in acpi.c:piix4_pm_init() by setting the SMM > inited bit in the PCI config space for the piix4. It's hackish, but it > avoids needing a KVM-specific BIOS. > Then something is broken there right now since without the comment Windows does not resumes. I'll check. -- Gleb. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-31 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20081230150725.4E4C925000A@cleopatra.tlv.redhat.com>
2008-12-30 16:34 ` [PATCH] kvm: bios: KVM does not support SMM, so disable it Anthony Liguori
2008-12-31 6:45 ` Gleb Natapov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox