From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] qemu: report issues causing the kvm probe to fail v3 Date: Thu, 08 Jan 2009 14:34:38 -0600 Message-ID: <4966635E.8090205@us.ibm.com> References: <1231422848-32179-1-git-send-email-ehrhardt@linux.vnet.ibm.com> Reply-To: qemu-devel@nongnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, avi@qumranet.com, kvm@vger.kernel.org To: ehrhardt@linux.vnet.ibm.com Return-path: In-Reply-To: <1231422848-32179-1-git-send-email-ehrhardt@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > The patch applies to upstream qemu as well as kvm-userspace, but since it is > the qemu configure script I think it should go to upstream qemu (Anthony) > first and with the next merge to kvm-userspace. On the other hand it is the kvm > probe so an ack from Avi in case v3 is ok would be reasonable. > > *updates* > v2 - it also reports other errors than just #error preprocessor statements > (requested by Avi) > v3 - In case awk or grep is not installed it now gracfully (silently) > fails still disabling kvm (requested by Anthony) > > This patch is about reporting more details of the issue if configuring kvm > fails. Therefore this patch keeps the qemu style configure output which is a > list of "$Feature $Status", but extend the "no" result like "KVM Support no" > with some more information. > > There might be a lot of things going wrong with that probe and I don't want > to handle all of them, but if it is one of the known checks e.g. for > KVM_API_VERSION then we could grep/awk that out and report it. The patch > reports in case of a known case in the style > "KVM support no - (Missing KVM capability KVM_CAP_DESTROY_MEMORY_REGION_WORKS)" > > In case more than one #error is triggered it creates a comma separated list in > those brackets and in case it is something else than an #error it just reports > plain old "no". > > Signed-off-by: Christian Ehrhardt > --- > > configure | 27 ++++++++++++++++++++------- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/qemu/configure b/qemu/configure > --- a/qemu/configure > +++ b/qemu/configure > Please send against upstream QEMU. Regards, Anthony Liguori