From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 0/5][RFC] virtio-net: MAC filtering
Date: Fri, 09 Jan 2009 14:00:40 -0600
Message-ID: <4967ACE8.2030001@codemonkey.ws>
References: <1231349852.7109.79.camel@lappy> <200901091127.32987.paul@codesourcery.com> <4967A84E.9080908@codemonkey.ws> <200901091156.08710.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Alex Williamson <alex.williamson@hp.com>,
	kvm <kvm@vger.kernel.org>, Mark McLoughlin <markmc@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from yw-out-2324.google.com ([74.125.46.29]:37475 "EHLO
	yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755084AbZAIUAu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 9 Jan 2009 15:00:50 -0500
Received: by yw-out-2324.google.com with SMTP id 9so3080319ywe.1
        for <kvm@vger.kernel.org>; Fri, 09 Jan 2009 12:00:48 -0800 (PST)
In-Reply-To: <200901091156.08710.paul@codesourcery.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Paul Brook wrote:
>>>> A concern here is the growing size of the virtio-net I/O port space
>>>> config.  This series brings it up to 256 bytes with PCI resource
>>>>         
>>> This is one reason why IO ports are a reallybad idea. Use memory mapped
>>> register spaces like any other sane system and you won't have a problem.
>>>       
>> IO ports are much faster for notification than MMIO in KVM which is why
>> the space is currently IO ports.  It was never meant to hold very large
>> amounts of data.
>>     
>
> Huh, I'm surprised it makes any real difference. Other that initial setup, 
> isn't it just used to "kick" the devieonce after new dscriptors have been 
> added to the ring buffer? I'd expect to be a fairly expensive operation 
> (bouncing back to userspace).
>   

It's about 2x as expensive to go to userspace but only probably 1.5x 
expensive to do MMIO compared to PIO.  In the grand scheme of things, 
I'm not sure that it matters that much.  It's relatively simple for 
someone to try out the change and do some benchmarking.

The tougher thing is providing backwards compatible support.

Regards,

Anthony Liguori

> Paul
>