From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] qemu: fix configuring kvm probe when using --kerneldir Date: Fri, 09 Jan 2009 14:05:22 -0600 Message-ID: <4967AE02.7010104@us.ibm.com> References: <1231503054-10618-1-git-send-email-ehrhardt@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: avi@qumranet.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: ehrhardt@linux.vnet.ibm.com Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:50048 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755845AbZAIUFa (ORCPT ); Fri, 9 Jan 2009 15:05:30 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n09K5akJ004350 for ; Fri, 9 Jan 2009 15:05:36 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n09K5TP1190430 for ; Fri, 9 Jan 2009 15:05:29 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n09K4gXl008572 for ; Fri, 9 Jan 2009 15:04:42 -0500 In-Reply-To: <1231503054-10618-1-git-send-email-ehrhardt@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > There is already a variable kvm_cflags which gets the path of the kernel > includes when using --kerneldir. But eventually with newer kernels we all will > need arch/$arch/include too (my case was a incldue of asm/kvm.h which was not > found anymore). Headers in a full kernel source are not flattened to > one arch like they are if e.g. installed kernel headers are used. > > To fix that, the includes added to cflags depending on --kerneldir should also > contian the arch includes. The patch adds a special check for x86 because its > source layout recently changed, all others directly use arch/$cpu/include if > existent. > > Signed-off-by: Christian Ehrhardt > Applied. Thanks. Regards, Anthony Liguori > --- > > [diffstat] > configure | 6 ++++++ > 1 file changed, 6 insertions(+) > > [diff] > diff --git a/configure b/configure > --- a/configure > +++ b/configure > @@ -963,6 +963,12 @@ EOF > EOF > if test "$kerneldir" != "" ; then > kvm_cflags=-I"$kerneldir"/include > + if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) \ > + -a -d "$kerneldir/arch/x86/include" ; then > + kvm_cflags="$kvm_cflags -I$kerneldir/arch/x86/include" > + elif test -d "$kerneldir/arch/$cpu/include" ; then > + kvm_cflags="$kvm_cflags -I$kerneldir/arch/$cpu/include" > + fi > else > kvm_cflags="" > fi >