From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: MMU: drop zeroing on mmu_memory_cache_alloc Date: Sun, 11 Jan 2009 09:14:36 +0200 Message-ID: <49699C5C.9000106@redhat.com> References: <20090108194419.GA8176@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37571 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbZAKHOk (ORCPT ); Sun, 11 Jan 2009 02:14:40 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0B7EdgB022642 for ; Sun, 11 Jan 2009 02:14:39 -0500 In-Reply-To: <20090108194419.GA8176@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > Zeroing on mmu_memory_cache_alloc is unnecessary since: > > - Smaller areas are pre-allocated with kmem_cache_zalloc. > - Page pointed by ->spt is overwritten with prefetch_page > and entries in page pointed by ->gfns are initialized > before reading. > > [avi: zeroing pages is unnecessary] > > Applied, thanks. -- error compiling committee.c: too many arguments to function