From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/7] KVM: Add a route layer to convert MSI message to GSI Date: Sun, 11 Jan 2009 11:40:48 +0200 Message-ID: <4969BEA0.6010905@redhat.com> References: <1231411535-2461-1-git-send-email-sheng@linux.intel.com> <1231411535-2461-2-git-send-email-sheng@linux.intel.com> <496616E9.5040007@redhat.com> <200901091050.59817.sheng@linux.intel.com> <49679209.1030600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42506 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbZAKJkv (ORCPT ); Sun, 11 Jan 2009 04:40:51 -0500 In-Reply-To: <49679209.1030600@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > > 1. add/remove ioctls > > The advantage is that very little work needs to be done when something > changes, but the code size (and bug count) doubles. > One disadvantage of add/remove is that we cannot effect a change atomically. Probably not a big deal, but something to keep in mind. -- error compiling committee.c: too many arguments to function