From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions Date: Sun, 11 Jan 2009 12:46:49 +0200 Message-ID: <4969CE19.7030009@redhat.com> References: <1231670495-17916-1-git-send-email-amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46058 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbZAKKqw (ORCPT ); Sun, 11 Jan 2009 05:46:52 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0BAkph1014875 for ; Sun, 11 Jan 2009 05:46:51 -0500 In-Reply-To: <1231670495-17916-1-git-send-email-amit.shah@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > The CPUID instruction takes the value of ECX as an input parameter > in addition to the value of EAX for function 4. Make sure we pass > the value to the instruction. > > This needs to go to upstream qemu. I'd suggest adding a new parameter rather than making ecx an in/out parameter. I'd expect a loop when we use this... -- error compiling committee.c: too many arguments to function