From: Avi Kivity <avi@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions
Date: Sun, 11 Jan 2009 13:23:32 +0200 [thread overview]
Message-ID: <4969D6B4.9000507@redhat.com> (raw)
In-Reply-To: <20090111105715.GA19556@amit-x200.pnq.redhat.com>
Amit Shah wrote:
> On Sun, Jan 11, 2009 at 12:46:49PM +0200, Avi Kivity wrote:
>
>> Amit Shah wrote:
>>
>>> The CPUID instruction takes the value of ECX as an input parameter
>>> in addition to the value of EAX for function 4. Make sure we pass
>>> the value to the instruction.
>>>
>>>
>>>
>> This needs to go to upstream qemu. I'd suggest adding a new parameter
>> rather than making ecx an in/out parameter.
>>
>
> You mean something like
>
> host_cpuid(index, subindex, eax, ebx, ecx, edx);
>
> ?
>
>
Yes.
>> I'd expect a loop when we use this...
>>
>
> Why a loop? We'll only return the values true for a particular EAX:ECX
> combination. The requestor (kernel) will loop.
>
The kernel doesn't call host_cpuid(). We preload all possible
combinations of eax and ecx in advance.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-01-11 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 10:41 [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions Amit Shah
2009-01-11 10:46 ` Avi Kivity
2009-01-11 10:57 ` Amit Shah
2009-01-11 11:23 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4969D6B4.9000507@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox