From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Mark McLoughlin <markmc@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: qemu: virtio-net: migration fixes
Date: Mon, 12 Jan 2009 09:09:01 +0200 [thread overview]
Message-ID: <496AEC8D.2070208@redhat.com> (raw)
In-Reply-To: <496AA0B2.1080909@codemonkey.ws>
Anthony Liguori wrote:
>> +
>> +#ifdef TAP_VNET_HDR
>> + qemu_put_be32(f, tap_has_vnet_hdr(n->vc->vlan->first_client));
>> +#endif
>>
>
> This should increment the save/restore format version number to
> preserve backwards compatibility. It'll also be required for merging
> into QEMU upstream.
>
> As a rule, if new fields are added to a save/load function, the
> version number should be incremented.
That only works if this is the very next change in qemu upstream. If
you accept another fix first, or require changes to this fix, then we're
out of luck.
I don't see any solution except continuing to merge.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2009-01-12 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090111142130.3EEC625000B@cleopatra.tlv.redhat.com>
2009-01-12 1:45 ` [PATCH] kvm: qemu: virtio-net: migration fixes Anthony Liguori
2009-01-12 7:09 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496AEC8D.2070208@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox