From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Store multiple cpuid entries for a single function Date: Tue, 13 Jan 2009 11:45:55 +0200 Message-ID: <496C62D3.2070208@redhat.com> References: <1231757365-15717-1-git-send-email-amit.shah@redhat.com> <1231757365-15717-2-git-send-email-amit.shah@redhat.com> <1231757365-15717-3-git-send-email-amit.shah@redhat.com> <496C5E6B.8010304@redhat.com> <20090113094022.GB22533@amit-x200.pnq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44833 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbZAMJp6 (ORCPT ); Tue, 13 Jan 2009 04:45:58 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0D9jwQk028982 for ; Tue, 13 Jan 2009 04:45:58 -0500 In-Reply-To: <20090113094022.GB22533@amit-x200.pnq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: >> Use the SET_CPUID2 interface instead. >> > > OK; So first attempt to use the SET_CPUID2 interface. If that fails (new > userspace on older kernel), what should we do? > SET_CPUID2 was introduced on 2.6.25; that is now the minimum requirement for qemu and kvm-userspace anyway. -- error compiling committee.c: too many arguments to function