From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [ANNOUNCE] kvm-83 release
Date: Tue, 13 Jan 2009 23:32:37 +0300
Message-ID: <496CFA65.9000706@msgid.tls.msk.ru>
References: <496C9CE0.2080103@redhat.com>  <496CBE09.4060801@wonghome.net> <1231867653.4290.196.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Cc: John Wong <johnw@wonghome.net>, Avi Kivity <avi@redhat.com>,
	KVM list <kvm@vger.kernel.org>
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from hobbit.corpit.ru ([81.13.33.150]:23178 "EHLO hobbit.corpit.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753927AbZAMUck (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 13 Jan 2009 15:32:40 -0500
In-Reply-To: <1231867653.4290.196.camel@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mark McLoughlin wrote:
> Hi John,
> 
> On Wed, 2009-01-14 at 00:15 +0800, John Wong wrote:
>> Hi, i installed kvm-83 on xubuntu-amd64/kernel-2.6.7-11.
>> i notice some problem with -net downscript.
>> my kvm start up script like this:
>> qemu-system-x86_64 ... ... -net 
>> tap,ifname=tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown
>> when the guest shutdown, kvm pass all argument to downscript.
>>
>> the command like this (kvm-83):
>> /path/kvm-ifdown
>> "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown"
>>
>> kvm-82 only pass tap0 to downscript like this:
>> /path/kvm-ifdown "tap0"
> 
> Thanks for the report. Can you try this simple change and see if it
> fixes it for you?
> 
> --- qemu/net.c
> +++ qemu/net.c
> @@ -1740,7 +1740,7 @@ void net_cleanup(void)
>                  TAPState *s = vc->opaque;
>  
>                  if (strcmp(vc->model, "tap") == 0 &&
> -                    sscanf(vc->info_str, "ifname=%63s ", ifname) == 1 &&
> +                    sscanf(vc->info_str, "ifname=%63s,", ifname) == 1 &&

Hmm.  What if ifname=foo is the last parameter?

/mjt