From: Anthony Liguori <anthony@codemonkey.ws>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Mark McLoughlin <markmc@redhat.com>,
John Wong <johnw@wonghome.net>, Avi Kivity <avi@redhat.com>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [ANNOUNCE] kvm-83 release
Date: Tue, 13 Jan 2009 14:37:34 -0600 [thread overview]
Message-ID: <496CFB8E.1060407@codemonkey.ws> (raw)
In-Reply-To: <496CFB29.6070809@msgid.tls.msk.ru>
Michael Tokarev wrote:
> Michael Tokarev wrote:
>
>> Mark McLoughlin wrote:
>>
> []
>
>>> --- qemu/net.c
>>> +++ qemu/net.c
>>> @@ -1740,7 +1740,7 @@ void net_cleanup(void)
>>> TAPState *s = vc->opaque;
>>>
>>> if (strcmp(vc->model, "tap") == 0 &&
>>> - sscanf(vc->info_str, "ifname=%63s ", ifname) == 1 &&
>>> + sscanf(vc->info_str, "ifname=%63s,", ifname) == 1 &&
>>>
>> Hmm. What if ifname=foo is the last parameter?
>>
>
> And while we're at it.. Why the parsing isn't done like this:
>
> for(tok = strtok(arg, ","); tok; tok = strtok(NULL, ",")) {
> if (strncmp(tok, "ifname=", 7) == 0)
> strcpy(ifname, tok+7);
> else if ...
> }
>
Because strtok is extremely evil.
Regards,
Anthony Liguori
> -- here and everywhere else?
>
> /mjt
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-01-13 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 13:53 [ANNOUNCE] kvm-83 release Avi Kivity
2009-01-13 15:54 ` Farkas Levente
2009-01-15 14:00 ` Avi Kivity
2009-01-15 20:17 ` Farkas Levente
2009-01-13 16:15 ` John Wong
2009-01-13 17:27 ` Mark McLoughlin
2009-01-13 17:40 ` John Wong
2009-01-13 18:22 ` Amit Shah
2009-01-13 20:32 ` Michael Tokarev
2009-01-13 20:35 ` Michael Tokarev
2009-01-13 20:37 ` Anthony Liguori [this message]
2009-01-13 21:01 ` Michael Tokarev
2009-01-13 22:30 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496CFB8E.1060407@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=johnw@wonghome.net \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox